From 25c623dd59bd15680d76aec8fb8e1a33434258d1 Mon Sep 17 00:00:00 2001
From: Martin Pitt <mpitt@redhat.com>
Date: Fri, 11 Oct 2024 09:33:50 +0200
Subject: [PATCH] appstream: Fix validation problems

Rename the file to match its ID, add developer tag, and extend the
description. This fixes all issues with `appstreamcli validate`:

> I: org.cockpit_project.starter_kit:10: description-first-para-too-short
>      Scaffolding for a cockpit module.
> I: org.cockpit_project.starter_kit:~: developer-info-missing
> W: org.cockpit_project.starter_kit:~: metainfo-filename-cid-mismatch
---
 Makefile                                                    | 2 +-
 ...info.xml => org.cockpit_project.starter_kit.metainfo.xml | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)
 rename org.cockpit-project.starter-kit.metainfo.xml => org.cockpit_project.starter_kit.metainfo.xml (78%)

diff --git a/Makefile b/Makefile
index 35e3419..995df96 100644
--- a/Makefile
+++ b/Makefile
@@ -10,7 +10,7 @@ TARFILE=$(RPM_NAME)-$(VERSION).tar.xz
 NODE_CACHE=$(RPM_NAME)-node-$(VERSION).tar.xz
 SPEC=$(RPM_NAME).spec
 PREFIX ?= /usr/local
-APPSTREAMFILE=org.cockpit-project.$(PACKAGE_NAME).metainfo.xml
+APPSTREAMFILE=org.cockpit_project.$(subst -,_,$(PACKAGE_NAME)).metainfo.xml
 VM_IMAGE=$(CURDIR)/test/images/$(TEST_OS)
 # stamp file to check for node_modules/
 NODE_MODULES_TEST=package-lock.json
diff --git a/org.cockpit-project.starter-kit.metainfo.xml b/org.cockpit_project.starter_kit.metainfo.xml
similarity index 78%
rename from org.cockpit-project.starter-kit.metainfo.xml
rename to org.cockpit_project.starter_kit.metainfo.xml
index 8e19746..4430d28 100644
--- a/org.cockpit-project.starter-kit.metainfo.xml
+++ b/org.cockpit_project.starter_kit.metainfo.xml
@@ -7,6 +7,9 @@
   <description>
     <p>
       Scaffolding for a cockpit module.
+
+      This is just a demo which does not do much. Please replace
+      this with a real description.
     </p>
   </description>
   <extends>org.cockpit_project.cockpit</extends>
@@ -14,4 +17,7 @@
   <url type="homepage">https://github.com/cockpit-project/starter-kit</url>
   <url type="bugtracker">https://github.com/cockpit-project/starter-kit/issues</url>
   <update_contact>cockpit-devel_AT_lists.fedorahosted.org</update_contact>
+  <developer id="org.cockpit-project">
+    <name>Cockpit Project</name>
+  </developer>
 </component>