From 4171293c48566a826b26c6f02810a822efeb958d Mon Sep 17 00:00:00 2001 From: Martin Pitt Date: Thu, 25 Feb 2021 06:24:04 +0100 Subject: [PATCH] Drop unused version numbers from package.json and manifest This field was introduced in https://github.com/cockpit-project/cockpit/pull/4964 as "purely informational for now", and isn't even parsed by cockpit. package.json's version would only be relevant for publishing NPM modules, but cockpit pages are not that. Neither starter-kit itself nor our derived projects like cockpit-podman or cockpit-composer have ever maintained these two fields, so just get rid of them. This makes the git tag the single source of truth for the version number. Fixes #200 --- package.json | 1 - src/manifest.json | 1 - 2 files changed, 2 deletions(-) diff --git a/package.json b/package.json index 386bcbc..880ca82 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,5 @@ { "name": "starter-kit", - "version": "0.1.0", "description": "Scaffolding for a cockpit module", "main": "index.js", "repository": "git@github.com:cockpit/starter-kit.git", diff --git a/src/manifest.json b/src/manifest.json index 3e2454a..3a45f56 100644 --- a/src/manifest.json +++ b/src/manifest.json @@ -1,5 +1,4 @@ { - "version": "0.1", "requires": { "cockpit": "137" },