From 4be61896eaf4d85bcb8e63e24ec00b89df214f62 Mon Sep 17 00:00:00 2001 From: Katerina Koukiou Date: Mon, 8 Nov 2021 10:47:32 +0100 Subject: [PATCH] package.json: use sass instead of node-sass node-sass is a compiled ELF module, which is problematic for distributions that want to rebuild everything from source. The sassc CLI program is packaged everywhere, and both use the same libsass library. So drop node-sass and replace it with sass which is also what cockpit and other external plugins are using. Port alerts in PF-react-core and fix missing icons in alerts --- Makefile | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 4d64e47..1345e56 100644 --- a/Makefile +++ b/Makefile @@ -67,7 +67,7 @@ dist/po.%.js: po/%.po $(NODE_MODULES_TEST) %.spec: %.spec.in sed -e 's/%{VERSION}/$(VERSION)/g' $< > $@ -$(WEBPACK_TEST): $(NODE_MODULES_TEST) $(shell find src/ -type f) package.json webpack.config.js $(patsubst %,dist/po.%.js,$(LINGUAS)) +$(WEBPACK_TEST): $(LIB_TEST) $(NODE_MODULES_TEST) $(shell find src/ -type f) package.json webpack.config.js $(patsubst %,dist/po.%.js,$(LINGUAS)) NODE_ENV=$(NODE_ENV) npm run build watch: diff --git a/package.json b/package.json index 4c467b3..2ded3af 100644 --- a/package.json +++ b/package.json @@ -36,8 +36,8 @@ "htmlparser": "^1.7.7", "jed": "^1.1.1", "mini-css-extract-plugin": "^0.9.0", - "node-sass": "^4.14.1", "po2json": "^1.0.0-alpha", + "sass": "^1.35.1", "sass-loader": "^7.0.3", "sizzle": "^2.3.3", "stdio": "^0.2.7",