From a6508f5d9935cc51a61e2d554d0ccf1c12f34881 Mon Sep 17 00:00:00 2001 From: Pino Toscano Date: Thu, 12 May 2022 16:23:54 +0200 Subject: [PATCH] spec: move AppStream validation to %check https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ suggests that can be in either; it is slightly more logical in %check. Reported by Neal Gompa, thanks! --- packaging/cockpit-starter-kit.spec.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packaging/cockpit-starter-kit.spec.in b/packaging/cockpit-starter-kit.spec.in index 47052bf..278c5b7 100644 --- a/packaging/cockpit-starter-kit.spec.in +++ b/packaging/cockpit-starter-kit.spec.in @@ -34,12 +34,13 @@ ESLINT=0 NODE_ENV=production make %install %make_install -appstream-util validate-relax --nonet %{buildroot}/%{_datadir}/metainfo/* # drop source maps, they are large and just for debugging find %{buildroot}%{_datadir}/cockpit/ -name '*.map' | xargs --no-run-if-empty rm --verbose %check +appstream-util validate-relax --nonet %{buildroot}/%{_datadir}/metainfo/* + # this can't be meaningfully tested during package build; tests happen through # FMF (see plans/all.fmf) during package gating