Commit graph

535 commits

Author SHA1 Message Date
Martin Pitt
51292fbc25 packit: Drop obsolete sandcastle hack
Since commit 9d4c08ff2a, SRPM builds happen in COPR, so we can drop the
sandcastle hack.

Also drop the duplicated `post-upstream-clone` key.
2022-06-07 17:09:25 +02:00
Martin Pitt
03a6cc94a3 Pick up cockpit test API fix for Firefox 101
See https://github.com/cockpit-project/cockpit/pull/17429 . This fixes
tests with Firefox version 101.
2022-06-06 20:53:36 +02:00
Cockpit Project
52ebda2575 package.json: Update @patternfly/patternfly, @patternfly/react-core
Closes #580
2022-06-06 08:22:58 +02:00
Cockpit Project
5cbfb7bf11 package.json: Update @patternfly/react-core
Closes #578
2022-05-23 07:04:20 +02:00
Cockpit Project
c185d34cee package.json: Update @patternfly/patternfly, @patternfly/react-core
Closes #576
2022-05-16 07:45:42 +02:00
Pino Toscano
a6508f5d99 spec: move AppStream validation to %check
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/
suggests that can be in either; it is slightly more logical in %check.

Reported by Neal Gompa, thanks!
2022-05-12 16:43:56 +02:00
Pino Toscano
e3f668b584 spec: use %autosetup
Replace the two %setup calls with %autosetup; the second call was even
redoing the first.

Reported by Neal Gompa, thanks!
2022-05-12 16:43:56 +02:00
Martin Pitt
f86c02c60e spec: Add an empty %check section
Add a comment where and how the package is being tested, to show that
it's not simply a forgotten section.
2022-05-10 09:51:50 +02:00
Martin Pitt
bee838088d spec: Clean up pre-existing dist/ in %prep
By convention.

See https://bugzilla.redhat.com/show_bug.cgi?id=1969450
2022-05-10 09:51:50 +02:00
Martin Pitt
0c954dbf49 spec: Set ExclusiveArch:
This forces the package build to happen on a koji builder which actually
supports node. It's pointless at runtime (as the code runs in a browser,
not through node), but in practice, `nodejs_arches` encompasses all
supported Fedora/RHEL architectures anyway.

https://docs.fedoraproject.org/en-US/packaging-guidelines/Node.js/#_exclusivearch
2022-05-10 09:51:50 +02:00
Pino Toscano
b47bb4714a spec: use nodejs-devel on Fedora
According to the Fedora guidelines, nodejs-devel is needed for using
nodejs modules:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Node.js/#_buildrequires

Since this applies only on Fedora, and that nodejs-devel may not even
exist on other distros (e.g. CentOS 9 Stream), then limit the
nodejs-devel requirement only to Fedora, keep using nodejs
unconditionally everywhere.
2022-05-10 09:51:50 +02:00
Cockpit Project
0763174e15 package.json: Update @patternfly/patternfly, @patternfly/react-core
Closes #572
2022-05-09 07:24:09 +02:00
Martin Pitt
c639ffc276 Move example COPR release to packit
This replaces the cockpituous job.
2022-05-03 10:30:13 +02:00
Cockpit Project
bdd376e9e0 package.json: Update @patternfly/patternfly, @patternfly/react-core
Closes #569
2022-05-02 12:15:37 +02:00
Pino Toscano
0ece83483d Makefile: avoid spurious echo
Disable the printing of the echo commands that write the filename of the
VM image for tests in the 'vm' and 'print-vm' targets.

This makes it possible to use their outputs, especially the 'print-vm'
target.
2022-04-27 06:55:58 +02:00
Cockpit Project
c990f74d73 package.json: Update @patternfly/patternfly, @patternfly/react-core
Closes #567
2022-04-25 06:22:08 +02:00
Martin Pitt
3aff8acad1 webpack: Always regenerate and clean up dist/
By default, webpack does not clean up dist/, so when you e.g. touch the
code and rebuild with `NODE_ENV=devel`, the old compressed assets from
a previous `production` build were left in place, and cockpit could
serve the old wrong ones. Enable the `clean` output option to fix this [1].

Also force the rewrite of all files with `compareBeforeEmit: false`, so
that the time stamps actually get updated on a webpack run. This fixes
`make` rules and unnecessary rebuilds when nothing changed.

Fixes #563

[1] https://webpack.js.org/configuration/output/#outputclean
2022-04-21 15:26:00 +02:00
Martin Pitt
a937b82cd2 test: Bump Cockpit test API to 267, use --track-naughties option
run-tests recently got a new `--track-naughties` option [1] to explicitly
enable updating known issues on GitHub. Enable it for CI runs, and leave
it disabled for local runs and PackIt, as in these cases we don't want
to try and talk to GitHub.

[1] 7ef88e80ce
2022-04-19 13:14:21 +02:00
Cockpit Project
5cf73c315a package.json: Update @patternfly/patternfly, @patternfly/react-core
Closes #560
2022-04-19 06:31:13 +02:00
Matej Marusak
e91487b558 workflows: Split npm-update to PF and non PF tasks
Run PF update every Monday and anything else try to update on Tue, Thu and Sat.
2022-04-13 10:39:32 +02:00
Cockpit Project
b1fb98b436 package.json: Update @patternfly/react-core
Closes #557
2022-04-13 06:23:17 +02:00
Cockpit Project
ff9ec35cb3 package.json: Update @patternfly/patternfly, @patternfly/react-core
Closes #556
2022-04-12 07:55:44 +02:00
Katerina Koukiou
fe1a9a387f package.json: bump eslint to ^8.0.0 and all eslint-x dependencies
So as to satisfy the new eslint peer dependency.

In addition drop eslint-config-standard-react as it does not release
anymore, and eslint 8.x is not compatible with the available last
release.
https://github.com/standard/eslint-config-standard-react/pull/69

Replace it with https://github.com/facebook/create-react-app#readme
which is actively maintained.

Lastly drop the deprecated
https://github.com/standard/eslint-plugin-standard
2022-04-11 07:56:29 +02:00
Martin Pitt
e069cbbfbd spec: Don't run eslint
It's useless there -- any style error that may happen there has already
slipped through the upstream release, and at RPM build time there is
nothing that can be done about it. It just wastes time.

This allows us to bump eslint to a newer version which is incompatible
with the older node.js on RHEL/CentOS 8.
2022-04-11 07:56:29 +02:00
Cockpit Project
7a0968bd8c package.json: Update @patternfly/patternfly, @patternfly/react-core
Closes #553
2022-04-11 06:24:31 +02:00
Martin Pitt
b2379f78e2 workflows: Drop livetest
We have not used that in a long time, and it stopped working a while
ago.
2022-04-05 18:43:14 +02:00
Pino Toscano
ce263cc4b2 metainfo: add few more URLs/references
Even if this module is a template, add a couple more of keys to the
AppStream XML file; this way other projects can get few more hints.
2022-04-04 17:08:17 +02:00
Pino Toscano
e3fba6c5c6 README: fix some links
- use https when possible (mostly for cockpit-project.org URLs)
- fix the references to the cockpit and tmt official repositories
- update one packit.dev URL
2022-04-01 16:56:22 +02:00
Pino Toscano
731bf26405 README: mention devel-install & devel-uninstall 2022-03-31 10:35:11 +02:00
Pino Toscano
fde873e0bd Makefile: add convenience 'devel-uninstall' target
Add a simple convenience target to "undo" what the devel-install did
(creating a symlink to ~/.local/share/cockpit), i.e. simply removing
that symlink.

Suggested by: Christopher Snyder
2022-03-31 10:35:11 +02:00
Pino Toscano
9357e55fc6 Makefile: add convenience 'print-vm' target
Add a simple convenience target that prints the filename of the test
image without creating it beforehand. This can be useful to know what is
the expected filename, so it is possible to provide an own test image
instead of the generated one.
2022-03-31 10:01:53 +02:00
Pino Toscano
29abcaab98 Makefile: set reproducible args for tar
When creating the tarballs for sources and node modules, apply some
hardening to the tar compression to remove some variances that may cause
the tarballs to not be reproducible; in particular:
- set fixed modes, and ownership
- set the mtime from the author's timestamp of the top-level commit
- sort the files by name
2022-03-25 09:25:06 +01:00
Pino Toscano
0e0d5bedc5 po: ignore js/jsx/html files under src/lib
Cockpit's PF/React/build library (pkg/lib from cockpit.git) is checked
out as src/lib, so exclude it from the search of js/jsx, and html
sources for the extraction of i18n messages.

This avoids the cockpit messages in case the message extraction is
performed in a source tree after build.
2022-03-23 19:20:19 +01:00
Pino Toscano
c2d704e130 Makefile: add convenience 'srpm' target
Add a simple 'srpm' target that builds the src.rpm file for the current
project.

Partially reverts commit b2662eeebd (at
least to bring the 'srpm' target back).
2022-03-22 14:11:27 +01:00
Pino Toscano
a46b26a8ff Makefile: depend on test/vm.install for the VM image target
Make sure to recreate the VM image in case the test/vm.install script
changes.
2022-03-18 09:10:55 +01:00
Martin Pitt
65bf109fad test: Add quirk for cockpit 265 shell menu translation regression
[1] regressed the translations of menu labels for external projects.
This will get fixed in the next version [2]. Adjust the tests to not
break with Cockpit version == 265.

[1] af5678b0be
[2] https://github.com/cockpit-project/cockpit/pull/17145
2022-03-17 11:43:39 +01:00
Martin Pitt
8862b2b497 test: Restrict language switching reload hack to affected browser/version
This was fixed in Cockpit 265, and has only ever affected Chromium, not
Firefox. Restrict the hack accordingly, to make sure this does not
regress again.
2022-03-17 11:43:39 +01:00
Martin Pitt
2f92610f28 Bump cockpit lib and test API to 265
Drop the obsolete expect_load().
2022-03-17 11:43:39 +01:00
Martin Pitt
e2d5995323 Quiesce mock
Drop the image-customize `--verbose` option. mock is incredibly blabbery
about its internals otherwise, and seeing the build log isn't
particularly interesting.
2022-03-17 11:43:39 +01:00
Pino Toscano
80b8949192 Makefile: allow setup of integration tests w/o running them
Add a convenience target in Makefile to perform all the setup targets
for integration tests without actually running them.
2022-03-17 10:21:57 +01:00
Cockpit Project
3dc7c804a0 package.json: Update @patternfly/patternfly, @patternfly/react-core
Closes #540
2022-03-12 10:48:12 +01:00
Tomas Tomecek
9d4c08ff2a packit: build SRPM in Copr
and be able to specify the precise list of deps needed to create the
SRPM

Details: https://packit.dev/posts/copr-srpms/

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
2022-03-10 16:29:53 +01:00
Pino Toscano
e0a1fb8a2b Makefile: factorize AppStream filename in own variable
Makes it easier to read, and also to modify for modules outside the
cockpit-project org.
2022-03-10 10:07:26 +01:00
Martin Pitt
6c123f94ec po: Update German translations
This validates the i18n for the AppStream metadata introduced in commit
4377c4fe19.
2022-03-09 22:30:00 +01:00
Pino Toscano
4377c4fe19 po: merge translations for metainfo file
When installing the module, instead of copying the metainfo file to the
destination, merge the available translations for it. Since this is done
at install time, add gettext as BuildRequires for the RPM packaging;
add libappstream-glib-devel as well only on RHEL/CentOS 8, since it
contains the metainfo.its for gettext in order to handle .metainfo.xml
files.

This requires a LINGUAS file with the list of translations currently
available: this is the way msgfmt picks the available languages to
merge. Generate it dynamically from the list of available .po files.
2022-03-09 16:02:26 +01:00
Pino Toscano
b5969c1c9b po: extract messages also for metainfo files
Recent versions of gettext know how to extract messages also from XML
files such as AppStream metadata. Hence, extract their messages, and
append them together with the global message catalog.
2022-03-09 16:02:26 +01:00
Pino Toscano
19300113fc po: do not hardcode the domain name
Use $(PACKAGE_NAME) to represent the current project.
2022-03-09 08:45:40 +01:00
Pino Toscano
e10a8702a7 spec: drop the debug_package %define
The generated RPM is noarch, so by definition has no binaries to extract
debug symbols from. Hence, drop the %define that makes RPM not error out
in case there are no debug symbols around (usually in archful binaries).
2022-03-09 07:15:49 +01:00
Cockpit Project
3d0f113680 package.json: Update @patternfly/patternfly, @patternfly/react-core
Closes #533
2022-02-24 08:32:18 +01:00
Martin Pitt
90ae15d812 test: Prepare VM image without networking
This ensures that we stay independent from any changes that go on in
online repositories, and our mock/pbuilders are sufficiently pre-cached.

Drop the explicit install of `cockpit-ws` -- all our bots images have it
pre-installed.
2022-02-22 14:26:15 +01:00