Techognito/starter-kit
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Drop unused version numbers from package.json and manifest

Browse source 
This field was introduced in
https://github.com/cockpit-project/cockpit/pull/4964 as "purely
informational for now", and isn't even parsed by cockpit.

package.json's version would only be relevant for publishing NPM
modules, but cockpit pages are not that.

Neither starter-kit itself nor our derived projects like cockpit-podman
or cockpit-composer have ever maintained these two fields, so just get
rid of them.

This makes the git tag the single source of truth for the version
number.

Fixes #200
This commit is contained in:
Martin Pitt 2021-02-25 06:24:04 +01:00 • committed by Katerina Koukiou
parent 66c6e96406
commit 4171293c48
2 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
package.json
View file

@ -1,6 +1,5 @@
{ {
"name": "starter-kit", "name": "starter-kit",
"version": "0.1.0",
"description": "Scaffolding for a cockpit module", "description": "Scaffolding for a cockpit module",
"main": "index.js", "main": "index.js",
"repository": "git@github.com:cockpit/starter-kit.git", "repository": "git@github.com:cockpit/starter-kit.git",

1
src/manifest.json
View file

@ -1,5 +1,4 @@
{ {
"version": "0.1",
"requires": { "requires": {
"cockpit": "137" "cockpit": "137"
}, },